Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CI against Elasticsearch 8 server #685

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jul 17, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Test against Elasticsearch 8 server.

Why?

Upgrade to the ES8 client would require some more work. But Elasticsearch 8 server supports client requests from ES7 client via: https://github.com/handcraftedinthealps/ElasticsearchBundle/blob/ab0f1adf3a627faa6b69175445e1e636ccdbbd29/Service/ManagerFactory.php#L141-L148 and so ES8 server can be used.

Attention ⚠️

Keep in mind for Full ES8 usage massiveart/MassiveSearchBundle#170 need also be tackled.

@alexander-schranz alexander-schranz added the Feature New functionality not yet included label Jul 17, 2024
@alexander-schranz alexander-schranz changed the title Test against Elasticsearch 8 server Test CI against Elasticsearch 8 server Jul 17, 2024
@alexander-schranz alexander-schranz marked this pull request as ready for review July 17, 2024 12:00
@alexander-schranz
Copy link
Member Author

@Prokyonn FYI

@alexander-schranz alexander-schranz merged commit 7b40fb2 into sulu:2.6 Jul 17, 2024
9 checks passed
@alexander-schranz alexander-schranz deleted the feature/elasticsearc-8 branch July 17, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant